chore(tests): replace __eq__() with diff() for detailed test diagnostics#314
Merged
chore(tests): replace __eq__() with diff() for detailed test diagnostics#314
Conversation
When test assertions fail, the error messages now show exactly which fields differ between expected and actual events, rather than just displaying raw protobuf dumps. This significantly improves debugging efficiency by pinpointing the specific mismatches in process attributes, event types, paths, and event-specific fields. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
597a859 to
c042b50
Compare
Stringy
approved these changes
Feb 25, 2026
Contributor
Stringy
left a comment
There was a problem hiding this comment.
Very minor nits, but otherwise LGTM
| event_field.old.path) | ||
| Event._diff_path(diff, 'old_host_path', | ||
| self.old_host_path, event_field.old.host_path) | ||
| return diff if diff else None |
Contributor
There was a problem hiding this comment.
[nit] this can be simplified a little
Suggested change
| return diff if diff else None | |
| return diff or None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When test assertions fail, the error messages now show exactly which fields differ between expected and actual events, rather than just displaying raw protobuf dumps. This significantly improves debugging efficiency by pinpointing the specific mismatches in process attributes, event types, paths, and event-specific fields.
Assisted-by: Claude Sonnet 4.5 noreply@anthropic.com
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Manually triggered an error in the test and got the following output: